Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13433: product builds secret configuration #7583

Merged
merged 7 commits into from
Jul 13, 2021

Conversation

jakubstilec
Copy link
Contributor

https://github.com/dotnet/core-eng/issues/13433 - secret manager configuration for product builds, these won't be executed until build pipeline is modified

To double check:

@jakubstilec jakubstilec changed the title product builds secret configuration #13433: product builds secret configuration Jul 1, 2021
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but I'd like to understand the "set to never expire" means in the context of a SAS token

@jakubstilec jakubstilec merged commit 1b053ba into dotnet:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants